Jess/697 write preserve enc state - #698
Merged
Merged
Conversation
cdawei
reviewed
Aug 5, 2026
| final currentContent = utf8.decode(await getResource(fileUrl)); | ||
| // Determine current encryption state | ||
| resolvedEncrypted = | ||
| isContentEncrypted(fileUrl: fileUrl, content: currentContent); |
Collaborator
There was a problem hiding this comment.
Hi Jess, thanks for the changes. As I briefly mentioned in the standup. A developer will be able to skip the check of a file's current encryption state by calling writePod() with arguments:
encrypted=trueoverwrite=true
I wonder if any feedback is necessary in such cases (e.g., a warning message, an error or exception)?
Collaborator
Author
There was a problem hiding this comment.
Thanks @cdawei I've added an exception to catch the scenario of encrypted = true, overwrite=true on an auth/public shared resource.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Description
WritePod and writeExternalPod() now check whether file encrypted if existing file, and then preserve that encryption state when overwriting.
Related Issues
Issue #697
Type of Change
How To Test?
Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising